This repository has been archived by the owner on May 9, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to make it clear that it is only applied for the back hcal
…e-for-several-tiny-patches
…f-the-back-hcal' into 68-meta-issue-for-several-tiny-patches
…ized-by-toa-correction' into 68-meta-issue-for-several-tiny-patches
…nto 68-meta-issue-for-several-tiny-patches
Adds reference to Tom's comment for context
…nto 68-meta-issue-for-several-tiny-patches
tomeichlersmith
approved these changes
Sep 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Thank you for pulling together all of these pieces 👍
bryngemark
approved these changes
Sep 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for cleaning up bits and pieces and especially for making the HCal veto ready for multi-electrons :)
This was referenced Sep 18, 2023
This was referenced Oct 31, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves a couple of different issues in the repository, namely #66, #67, #61, #58, and #18. Each of these issues have a dedicated branch so you can see the changes originating from each issue independent of each other. After merging these, this PR also runs clang-format on the relevant source files and refactors around warnings a bit.
This just adds configurable collection names for the hcal veto processor
This adds a default value for the maxPE hit in the hcal veto collection with all values set to negative numbers. This isn't ideal of course, but signalling values is easier to spot than junk/uninitialized memory.
This makes the rounding of the gain in the hcal trig primitives conditions explicit in the python configuration
This just marks the
TGraph
we use to do TOA correction as sorted so ROOT can use a binary search rather than linearly scanning through the entire graphFinally¸this PR does the following refactorings
these were never used so the bug shouldn't have caused any problems
#ifdef DEBUG
parts from the raw decoderWe had a bunch of processors that didn't have a corresponding header file. This made navigating the repo needlessly complicated and was hiding what processors we actually had in the repo. I'm more than happy to handle any merge conflicts that may arise from this refactoring :)
clang-format