Skip to content
This repository has been archived by the owner on May 9, 2024. It is now read-only.

68 meta issue for several tiny patches #70

Merged
merged 26 commits into from
Sep 18, 2023

Conversation

EinarElen
Copy link
Contributor

This PR resolves a couple of different issues in the repository, namely #66, #67, #61, #58, and #18. Each of these issues have a dedicated branch so you can see the changes originating from each issue independent of each other. After merging these, this PR also runs clang-format on the relevant source files and refactors around warnings a bit.

Finally¸this PR does the following refactorings

  • Mark destructors for classes with virtual functions virtual
  • Make trivial destructors and constructors defaulted
  • Remove or mark unused variables as TODO/maybe_unused
  • Patch a minor bug that clang's warnings caught
/home/einarelen/ldmx/ldmx-sw/Hcal/include/Hcal/HcalRawDecoder.h:347:23: warning: & has lower precedence than ==; == will be evaluated first [-Wparentheses]
            (w >> 15) & packing::utility::mask<1> == 1;
                      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/einarelen/ldmx/ldmx-sw/Hcal/include/Hcal/HcalRawDecoder.h:347:23: note: place parentheses around the '==' expression to silence this warning
            (w >> 15) & packing::utility::mask<1> == 1;
                      ^
                        (                             )

these were never used so the bug shouldn't have caused any problems

  • Remove the #ifdef DEBUG parts from the raw decoder
  • Add header files for all processors
    We had a bunch of processors that didn't have a corresponding header file. This made navigating the repo needlessly complicated and was hiding what processors we actually had in the repo. I'm more than happy to handle any merge conflicts that may arise from this refactoring :)
  • clang-format

to make it clear that it is only applied for the back hcal
…f-the-back-hcal' into 68-meta-issue-for-several-tiny-patches
…ized-by-toa-correction' into 68-meta-issue-for-several-tiny-patches
Adds reference to Tom's comment for context
@EinarElen EinarElen linked an issue Sep 15, 2023 that may be closed by this pull request
Copy link
Member

@tomeichlersmith tomeichlersmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thank you for pulling together all of these pieces 👍

Copy link

@bryngemark bryngemark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning up bits and pieces and especially for making the HCal veto ready for multi-electrons :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Meta issue for several tiny patches
3 participants